Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/6737#issuecomment-113935952
Sorry for flip-flopping, but I'm now worried that my suggestion for a test
isn't very useful. However, I think we can simplify it even further. Just set
maxIterations to 0, and test that the returned model is the same as the initial
one given. I think that should suffice.
Other than this + the issue with "runs" this look good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
