Github user mridulm commented on the pull request:
https://github.com/apache/spark/pull/791#issuecomment-43756945
@tdas as @cloud-fan stated, the code uses the implementation detail that
the private method is always called within context of a tryToPut lock - and not
called by anyone else. I dont like the fact that we have locking state spread
out like this, but then this is how it was already I guess ...
Maybe we should at best annotate the method ? And possibly assert that it
is within tryToPut lock ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
