Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6918#discussion_r32969205
--- Diff:
core/src/main/java/org/apache/spark/shuffle/unsafe/UnsafeShuffleWriter.java ---
@@ -147,8 +150,16 @@ public void
write(scala.collection.Iterator<Product2<K, V>> records) throws IOEx
closeAndWriteOutput();
success = true;
} finally {
- if (!success) {
- sorter.cleanupAfterError();
+ if (sorter != null) {
+ try {
+ sorter.cleanupAfterError();
+ } catch (Exception e) {
+ // Only throw this error if we won't be masking another
+ // error.
+ if (success) {
+ throw e;
+ }
--- End diff --
Shouldn't we log in the `else` branch to make sure that the error is never
silently swallowed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
