Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6954#discussion_r33057614
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/util/NumericParser.scala ---
@@ -19,6 +19,8 @@ package org.apache.spark.mllib.util
import java.util.StringTokenizer
+import org.apache.commons.lang.StringUtils.isBlank
--- End diff --
Don't use commons-lang -- it's not actually a dependency. I wouldn't even
use lang3. You don't need a utility class for something this simple
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
