Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6969#discussion_r33127178
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
@@ -636,7 +640,16 @@ class StreamingContext private[streaming] (
* if the waiting time elapsed before returning from the method.
*/
def awaitTerminationOrTimeout(timeout: Long): Boolean = {
- waiter.waitForStopOrError(timeout)
+ try {
+ waiter.waitForStopOrError(timeout)
+ } catch {
+ case e: InterruptedException =>
+ logger.info("StreamingContext interrupted at
awaitTerminationOrTimeout")
+ false
--- End diff --
You can't return `false` in this case, and I also don't think there is
value in also logging any exception here. Refer to the JIRA for the intended
change here, which was just a documentation update. You might close this PR and
just open a new one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
