Github user tarekauel commented on a diff in the pull request:
https://github.com/apache/spark/pull/6981#discussion_r33128876
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetime.scala
---
@@ -0,0 +1,229 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.catalyst.expressions
+
+import java.sql.Date
+import java.text.SimpleDateFormat
+
+import
org.apache.spark.sql.catalyst.expressions.codegen.{GeneratedExpressionCode,
CodeGenContext}
+import org.apache.spark.sql.catalyst.util.DateTimeUtils
+import org.apache.spark.sql.types._
+import org.apache.spark.unsafe.types.UTF8String
+
+case class DateFormat(left: Expression, right: Expression)
+ extends BinaryExpression with ExpectsInputTypes {
+
+ override def dataType: DataType = StringType
+
+ override def expectedChildTypes: Seq[DataType] = Seq(TimestampType,
StringType)
+
+ override def foldable: Boolean = left.foldable && right.foldable
+
+ override def nullable: Boolean = true
+
+ override def eval(input: InternalRow): Any = {
+ val valueLeft = left.eval(input)
+ if (valueLeft == null) {
+ null
+ } else {
+ val valueRight = right.eval(input)
+ if (valueRight == null) {
+ null
+ } else {
+ val sdf = new
SimpleDateFormat(valueRight.asInstanceOf[UTF8String].toString)
+ left.dataType match {
+ case TimestampType =>
+ UTF8String.fromString(sdf.format(new
Date(valueLeft.asInstanceOf[Long] / 10000)))
+ case DateType =>
+
UTF8String.fromString(sdf.format(DateTimeUtils.toJavaDate(valueLeft.asInstanceOf[Int])))
+ case StringType =>
+ UTF8String.fromString(
+
sdf.format(DateTimeUtils.stringToTime(valueLeft.asInstanceOf[UTF8String].toString)))
+ }
+ }
+ }
+ }
+
+ override def toString: String = s"DateFormat($left, $right)"
+
+ override protected def genCode(ctx: CodeGenContext, ev:
GeneratedExpressionCode): String = {
+ val sdf = "java.text.SimpleDateFormat"
+ val utf8 = "org.apache.spark.unsafe.types.UTF8String"
+ val dtUtils = "org.apache.spark.sql.catalyst.util.DateTimeUtils"
+
+ val eval1 = left.gen(ctx)
+ val eval2 = right.gen(ctx)
+
+ val calc = left.dataType match {
+ case TimestampType =>
+ s"""$utf8.fromString(sdf.format(new
java.sql.Date(${eval1.primitive} / 10000)));"""
+ case DateType =>
+ s"""$utf8.fromString(
+ sdf.format($dtUtils.toJavaDate(${eval1.primitive})));"""
+ case StringType =>
+ s"""
+ $utf8.fromString(sdf.format(new
java.sql.Date($dtUtils.stringToTime(${eval1.primitive}.toString()).getTime())));
+ """
+ }
+
+ s"""
+ ${eval1.code}
+ boolean ${ev.isNull} = ${eval1.isNull};
+ ${ctx.javaType(dataType)} ${ev.primitive} =
${ctx.defaultValue(dataType)};
+ if (!${ev.isNull}) {
+ ${eval2.code}
+ if (!${eval2.isNull}) {
+ $sdf sdf = new $sdf(${eval2.primitive}.toString());
+ ${ev.primitive} = $calc
+ } else {
+ ${ev.isNull} = true;
+ }
+ }
+ """
+ }
+}
+
+case class Year(child: Expression) extends UnaryExpression with
ExpectsInputTypes {
+
+ override def dataType: DataType = IntegerType
+
+ override def expectedChildTypes: Seq[DataType] = Seq(DateType,
StringType, TimestampType)
+
+ override def foldable: Boolean = child.foldable
+
+ override def nullable: Boolean = true
+
+ override def eval(input: InternalRow): Any = {
+ DateFormat(child, Literal("y")).eval(input) match {
--- End diff --
Is it okay to call `DateFormat(child, Literal("y")).eval(input)` or is
there a more elegant way.
Is there a way to call `genCode` of `DataFormat`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
