Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/6672#issuecomment-114872773
> I've noticed that you're not persisting the SparkListenerBlockUpdated
events in the event logging listener. Since there might be tons of these
events, I can understand why we might not want to persist them in the event
log, similar to how we don't persist ExecutorMetricsUpdate events. If this is
intentional, I think we should add an override and comment to
EventLoggingListener to make this more explicit:
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala#L201
@JoshRosen Forgot to add to `EventLoggingListener`. Do you think if people
want to see blocks in the history server? They are the final blocks when the
driver exits. Right? I think most of people are only interested in the ongoing
blocks when the application runs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
