Github user nollbit commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5563#discussion_r33154741
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
 ---
    @@ -171,12 +173,15 @@ private[spark] class CoarseMesosSchedulerBackend(
         synchronized {
           val filters = Filters.newBuilder().setRefuseSeconds(5).build()
     
    -      for (offer <- offers) {
    +      // filter out all the offers that do not meet constraints (if 
specified)
    +      val qualifyingOffers = filterOffersByConstraints(offers, 
slaveOfferConstraints)
    --- End diff --
    
    I might be wrong, but doesn't this mean that this framework misbehaves in 
that it does not decline offers that doesn't match the constraints? These are 
left hanging until they time out.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to