Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6952#discussion_r33277919
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -442,15 +442,17 @@ private[spark] class TaskSchedulerImpl(
synchronized {
if (activeExecutorIds.contains(executorId)) {
val hostPort = executorIdToHost(executorId)
- logError("Lost executor %s on %s: %s".format(executorId, hostPort,
reason))
+ lazy val msg = s"Lost executor $executorId on $hostPort: $reason"
+ if (!sc.isStopped) logError(msg)
removeExecutor(executorId)
failedExecutor = Some(executorId)
} else {
- // We may get multiple executorLost() calls with different loss
reasons. For example, one
- // may be triggered by a dropped connection from the slave while
another may be a report
- // of executor termination from Mesos. We produce log messages
for both so we eventually
- // report the termination reason.
- logError("Lost an executor " + executorId + " (already removed):
" + reason)
+ // We may get multiple executorLost() calls with different loss
reasons. For example, one
+ // may be triggered by a dropped connection from the slave while
another may be a report
+ // of executor termination from Mesos. We produce log messages for
both so we eventually
+ // report the termination reason.
+ lazy val msg = s"Lost an executor $executorId (already removed):
$reason"
+ if (!sc.isStopped) logError(msg)
--- End diff --
Same comments here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
