Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6973#issuecomment-115370523
hmm, now I am a little confused -- that test actually passes even without
your changes. Sorry this may have been my fault for suggesting a test in
`SparkContextSuite` -- I guess `SparkContext` itself already handles multiple
calls to `stop()`.
I'm not convinced this is still needed, but I suppose it doesn't hurt. In
any case, I'd leave the test you have, and also add a case where you just stop
the env multiple times.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
