Github user thegiive commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7038#discussion_r33364667
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/master/WorkerInfo.scala ---
    @@ -107,4 +107,8 @@ private[spark] class WorkerInfo(
       def setState(state: WorkerState.Value): Unit = {
         this.state = state
       }
    +
    +  def isAlive(): Boolean={
    --- End diff --
    
    The reason why I write a method here is due to JsonProtocol.scala  cannot 
access   WorkerState.ALIVE. 
    
    Changing the WorkerState from private to other permission is not good 
approach. I think it is the best way to keep the current class/namespace struct 
and get thing done. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to