Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6963#discussion_r33429310
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -140,3 +141,49 @@ case class Sha2(left: Expression, right: Expression)
"""
}
}
+
+/**
+ * A function that calculates a sha1 hash value and returns it as a hex
string
+ * For input of type [[BinaryType]] or [[StringType]]
+ */
+case class Sha1(child: Expression) extends UnaryExpression with
ExpectsInputTypes {
+
+ override def dataType: DataType = StringType
+
+ override def expectedChildTypes: Seq[DataType] = Seq(BinaryType,
StringType)
--- End diff --
This should be `Seq(BinaryType)`, you can checkout out
`ExpectedInputConversion` to see how `ExpectsInputTypes` works, take Sha2 as
example.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
