Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/7065#issuecomment-116443860 LGTM except a minor inline comment. Please create JIRAs and submit PRs for the following: 1. Java unit test 1. Python API 1. set ML attributes in the PCA output column Thanks!!
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org