Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/7082#discussion_r33462776
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala ---
@@ -572,55 +572,55 @@ private[ui] class StagePage(parent: StagesTab)
extends WebUIPage("stage") {
val attempt = taskInfo.attempt
val timelineObject =
s"""
- {
- 'className': 'task task-assignment-timeline-object',
- 'group': '$executorId',
- 'content': '<div class="task-assignment-timeline-content"' +
- 'data-toggle="tooltip" data-placement="top"' +
- 'data-html="true" data-container="body"' +
- 'data-title="${s"Task " + index + " (attempt " + attempt
+ ")"}<br>' +
- 'Status: ${taskInfo.status}<br>' +
- 'Launch Time: ${UIUtils.formatDate(new
Date(launchTime))}' +
- '${
+ |{
+ |'className': 'task task-assignment-timeline-object',
+ |'group': '$executorId',
+ |'content': '<div class="task-assignment-timeline-content"
+ |data-toggle="tooltip" data-placement="top"
+ |data-html="true" data-container="body"
+ |data-title="${s"Task " + index + " (attempt " + attempt
+ ")"}<br>
+ |Status: ${taskInfo.status}<br>
+ |Launch Time: ${UIUtils.formatDate(new Date(launchTime))}
+ |${
if (!taskInfo.running) {
s"""<br>Finish Time: ${UIUtils.formatDate(new
Date(finishTime))}"""
} else {
""
}
- }' +
- '<br>Scheduler Delay: $schedulerDelay ms' +
- '<br>Task Deserialization Time:
${UIUtils.formatDuration(deserializationTime)}' +
- '<br>Shuffle Read Time:
${UIUtils.formatDuration(shuffleReadTime)}' +
- '<br>Executor Computing Time:
${UIUtils.formatDuration(executorComputingTime)}' +
- '<br>Shuffle Write Time:
${UIUtils.formatDuration(shuffleWriteTime)}' +
- '<br>Result Serialization Time:
${UIUtils.formatDuration(serializationTime)}' +
- '<br>Getting Result Time:
${UIUtils.formatDuration(gettingResultTime)}">' +
- '<svg class="task-assignment-timeline-duration-bar">' +
- '<rect class="scheduler-delay-proportion" ' +
- 'x="$schedulerDelayProportionPos%" y="0px"
height="26px"' +
- 'width="$schedulerDelayProportion%""></rect>' +
- '<rect class="deserialization-time-proportion" '+
- 'x="$deserializationTimeProportionPos%" y="0px"
height="26px"' +
- 'width="$deserializationTimeProportion%"></rect>' +
- '<rect class="shuffle-read-time-proportion" ' +
- 'x="$shuffleReadTimeProportionPos%" y="0px"
height="26px"' +
- 'width="$shuffleReadTimeProportion%"></rect>' +
- '<rect class="executor-runtime-proportion" ' +
- 'x="$executorRuntimeProportionPos%" y="0px"
height="26px"' +
- 'width="$executorComputingTimeProportion%"></rect>' +
- '<rect class="shuffle-write-time-proportion" ' +
- 'x="$shuffleWriteTimeProportionPos%" y="0px"
height="26px"' +
- 'width="$shuffleWriteTimeProportion%"></rect>' +
- '<rect class="serialization-time-proportion" ' +
- 'x="$serializationTimeProportionPos%" y="0px"
height="26px"' +
- 'width="$serializationTimeProportion%"></rect>' +
- '<rect class="getting-result-time-proportion" ' +
- 'x="$gettingResultTimeProportionPos%" y="0px"
height="26px"' +
- 'width="$gettingResultTimeProportion%"></rect></svg>',
- 'start': new Date($launchTime),
- 'end': new Date($finishTime)
- }
- """
+ }
+ |<br>Scheduler Delay: $schedulerDelay ms
+ |<br>Task Deserialization Time:
${UIUtils.formatDuration(deserializationTime)}
+ |<br>Shuffle Read Time:
${UIUtils.formatDuration(shuffleReadTime)}
+ |<br>Executor Computing Time:
${UIUtils.formatDuration(executorComputingTime)}
+ |<br>Shuffle Write Time:
${UIUtils.formatDuration(shuffleWriteTime)}
+ |<br>Result Serialization Time:
${UIUtils.formatDuration(serializationTime)}
+ |<br>Getting Result Time:
${UIUtils.formatDuration(gettingResultTime)}">
+ |<svg class="task-assignment-timeline-duration-bar">
+ |<rect class="scheduler-delay-proportion"
+ |x="$schedulerDelayProportionPos%" y="0px" height="26px"
+ |width="$schedulerDelayProportion%""></rect>
+ |<rect class="deserialization-time-proportion"
+ |x="$deserializationTimeProportionPos%" y="0px"
height="26px"
+ |width="$deserializationTimeProportion%"></rect>
+ |<rect class="shuffle-read-time-proportion"
+ |x="$shuffleReadTimeProportionPos%" y="0px"
height="26px"
+ |width="$shuffleReadTimeProportion%"></rect>
+ |<rect class="executor-runtime-proportion"
+ |x="$executorRuntimeProportionPos%" y="0px"
height="26px"
+ |width="$executorComputingTimeProportion%"></rect>
+ |<rect class="shuffle-write-time-proportion"
+ |x="$shuffleWriteTimeProportionPos%" y="0px"
height="26px"
+ |width="$shuffleWriteTimeProportion%"></rect>
+ |<rect class="serialization-time-proportion"
+ |x="$serializationTimeProportionPos%" y="0px"
height="26px"
+ |width="$serializationTimeProportion%"></rect>
+ |<rect class="getting-result-time-proportion"
+ |x="$gettingResultTimeProportionPos%" y="0px"
height="26px"
+ |width="$gettingResultTimeProportion%"></rect></svg>',
+ |'start': new Date($launchTime),
+ |'end': new Date($finishTime)
+ |}
+ |""".stripMargin.replaceAll("\n", " ")
--- End diff --
I misunderstood the effect of "|" and stripMargin. Yes it's needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
