Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7014#discussion_r33468301
--- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala ---
@@ -97,11 +101,17 @@ case class ExceptionFailure(
description: String,
stackTrace: Array[StackTraceElement],
fullStackTrace: String,
- metrics: Option[TaskMetrics])
+ metrics: Option[TaskMetrics],
+ exception: Option[Throwable] = None)
--- End diff --
I think we're definitely out of luck for binary compatibility, but I think
@pwendell just wanted to preserve source compatibility (ie. maybe users will
need to recompile, but they won't need to change their code at all).
However, I don't think that is possible either. You would need to have
another method like `def unapply(ef: ExceptionFailure): Option[(String, String,
Array[StackTraceElement], String, Option[TaskMetrics])]` -- ie., exactly the
same as the built-in unapply, but without the final `Option[Throwable]` in the
return type. But that isn't legal overloading -- it has the same set of
arguments as the built-in `unapply`, just a different return type.
Is there another way around this I'm not seeing? I agree we shouldn't
change things willy-nilly just b/c its `@DeveloperApi`, but IMO this change is
worth it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
