Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/6830#issuecomment-116741414
Oh, that failure is due to a doctest "canary" test that I added to
`dev/run-tests.py`:
```
**********************************************************************
File "./dev/run-tests.py", line 97, in __main__.determine_modules_to_test
Failed example:
x # doctest: +NORMALIZE_WHITESPACE
Expected:
['examples', 'hive-thriftserver', 'mllib', 'pyspark-core',
'pyspark-ml', 'pyspark-mllib', 'pyspark-sql', 'pyspark-streaming',
'sparkr', 'sql']
Got:
['examples', 'hive-thriftserver', 'mllib', 'pyspark-ml',
'pyspark-mllib', 'pyspark-sql', 'sparkr', 'sql']
**********************************************************************
```
Just update that docstring to make the test pass. This test failure
actually reflects the fact that the old module definition was leading to
overtesting in PySpark core, since we'd re-test core even when only making SQL
changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
