Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/7058#issuecomment-116751724
LGTM. I used `pylint` / `prospector` to lint this file and it looks like
this has fixed all occurrences of the "dangerous-default-value" pattern in this
file.
In the future, it might be nice to enable a lint check for this as part of
the automated build checks, but lets do that separately (I've filed
https://issues.apache.org/jira/browse/SPARK-8706 for this).
@mengxr, I'll let you merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
