GitHub user zsxwing opened a pull request:

    https://github.com/apache/spark/pull/7088

    [SPARK-8705][WebUI]Don't display rects when totalExecutionTime is 0

    Because `System.currentTimeMillis()` is not accurate for tasks that only 
need several milliseconds, sometimes `totalExecutionTime` in `makeTimeline` 
will be 0. If `totalExecutionTime` is 0, there will the following error in the 
console.
    
    ![screen shot 2015-06-29 at 7 08 55 
pm](https://cloud.githubusercontent.com/assets/1000778/8406776/5cd38e04-1e92-11e5-89f2-0c5134fe4b6b.png)
    
    This PR fixes it by using an empty svg tag when `totalExecutionTime` is 0. 
This is a screenshot for a task that its totalExecutionTime is 0 after fixing 
it.
    
    ![screen shot 2015-06-30 at 12 26 52 
am](https://cloud.githubusercontent.com/assets/1000778/8412896/7b33b4be-1ebf-11e5-9100-d6d656af3747.png)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zsxwing/spark SPARK-8705

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/7088.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #7088
    
----
commit ef2ecfa285f38efbadafe91f21aae21a8159be9c
Author: zsxwing <zsxw...@gmail.com>
Date:   2015-06-29T16:29:41Z

    Don't display rects when totalExecutionTime is 0

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to