Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7026#discussion_r33487478
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/package.scala ---
@@ -32,13 +32,36 @@ package object client {
// Hive 0.14 depends on calcite 0.9.2-incubating-SNAPSHOT which does
not exist in
// maven central anymore, so override those with a version that exists.
//
- // org.pentaho:pentaho-aggdesigner-algorithm is also nowhere to be
found, so exclude
- // it explicitly. If it's needed by the metastore client, users will
have to dig it
- // out of somewhere and use configuration to point Spark at the
correct jars.
+ // The other excluded dependencies are also nowhere to be found, so
exclude them explicitly. If
+ // they're needed by the metastore client, users will have to dig them
out of somewhere and use
+ // configuration to point Spark at the correct jars.
case object v14 extends HiveVersion("0.14.0",
- Seq("org.apache.calcite:calcite-core:1.3.0-incubating",
+ extraDeps = Seq("org.apache.calcite:calcite-core:1.3.0-incubating",
"org.apache.calcite:calcite-avatica:1.3.0-incubating"),
- Seq("org.pentaho:pentaho-aggdesigner-algorithm"))
+ exclusions = Seq("org.pentaho:pentaho-aggdesigner-algorithm"))
+
+ case object v1_0 extends HiveVersion("1.0.0",
+ exclusions = Seq("eigenbase:eigenbase-properties",
+ "org.pentaho:pentaho-aggdesigner-algorithm",
+ "net.hydromatic:linq4j",
+ "net.hydromatic:quidem"))
+
+ // The curator dependency was added to the exclusions here because it
seems to confuse the ivy
+ // library. org.apache.curator:curator is a pom dependency but ivy
tries to find the jar for it,
+ // and fails.
+ case object v1_1 extends HiveVersion("1.1.0",
+ exclusions = Seq("eigenbase:eigenbase-properties",
+ "org.apache.curator:*",
+ "org.pentaho:pentaho-aggdesigner-algorithm",
+ "net.hydromatic:linq4j",
+ "net.hydromatic:quidem"))
+
+ case object v1_2 extends HiveVersion("1.2.0",
+ exclusions = Seq("eigenbase:eigenbase-properties",
+ "org.apache.curator:*",
+ "org.pentaho:pentaho-aggdesigner-algorithm",
+ "net.hydromatic:linq4j",
+ "net.hydromatic:quidem"))
--- End diff --
We don't need it, in the sense that the tests work, but it can avoid
downloading more unneeded things, so let me add those.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
