Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/5392#discussion_r33513905
--- Diff: core/src/main/scala/org/apache/spark/deploy/Client.scala ---
@@ -82,29 +92,38 @@ private class ClientActor(driverArgs: ClientArguments,
conf: SparkConf)
driverArgs.cores,
driverArgs.supervise,
command)
-
- // This assumes only one Master is active at a time
- for (masterActor <- masterActors) {
- masterActor ! RequestSubmitDriver(driverDescription)
- }
+ ayncSendToMasterAndForwardReply[SubmitDriverResponse](
+ RequestSubmitDriver(driverDescription))
case "kill" =>
val driverId = driverArgs.driverId
- // This assumes only one Master is active at a time
- for (masterActor <- masterActors) {
- masterActor ! RequestKillDriver(driverId)
- }
+
ayncSendToMasterAndForwardReply[KillDriverResponse](RequestKillDriver(driverId))
+ }
+ }
+
+ /**
+ * Send the message to master and forward the reply to self
asynchronously.
+ */
+ private def ayncSendToMasterAndForwardReply[T: ClassTag](message: Any):
Unit = {
+ for (masterEndpoint <- masterEndpoints) {
+ masterEndpoint.ask[T](message).onComplete {
+ case Success(v) => self.send(v)
+ case Failure(e) =>
+ println(s"Error sending messages to master $masterEndpoint,
exiting.")
--- End diff --
also let's make this the error message (should we be using println?)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
