Github user ankurcha commented on the pull request:
https://github.com/apache/spark/pull/5563#issuecomment-116881510
* Looking at the way this feature is being used (as per marathon) and the
age of the commits to the concerned attributes.cpp and values.cpp files, the
feature is pretty baked and only the documentation is out of date. That said, I
think it warrants atleast a bug against MESOS project so that it is correctly
documented.
* I think we should create a proper story / document around the best way to
go about the attributes with operators if needed. That said, my current
implementation around using subset and equality is motivated by a real use-case
of restricting executors to only start on tachyon-local boxes. I believe this
can be taken as a way to get ideas in and then expand based on others' use
cases as they happen to come up. I don't see the point in implementing a
complex operator parsing etc system without having an actual need in mind.
Personally, attempting to add complex operators seems like conflation on
concerns when thinking about resources and I would want to keep equality and
subset as the only operators for attributes.
I am going to add an implementation + tests based on my thoughts above and
@tnachen @dragos @squito can poke holes into my assumptions if i overlooked any.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
