Github user dragos commented on a diff in the pull request:
https://github.com/apache/spark/pull/7040#discussion_r33560845
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionals.scala
---
@@ -296,9 +295,7 @@ case class CaseKeyWhen(key: Expression, branches:
Seq[Expression]) extends CaseW
}
private def equalNullSafe(l: Any, r: Any) = {
- if (l == null && r == null) {
- true
- } else if (l == null || r == null) {
+ if (l == null || r == null) {
--- End diff --
This is far enough from Java/Scala semantics that it warrants a scaladoc
and a pointer to NULL semantics in SQL, IMO
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
