Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/7099#discussion_r33641114
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala
---
@@ -31,7 +31,8 @@ import org.apache.spark.sql.DataFrame
* @param predictionAndObservations an RDD of (prediction, observation)
pairs.
*/
@Experimental
-class RegressionMetrics(predictionAndObservations: RDD[(Double, Double)])
extends Logging {
+class RegressionMetrics(predictionAndObservations: RDD[(Double, Double)])
+ extends Logging with Serializable {
--- End diff --
Does this have to be Serializable?
If so, I'm not quite sure how extending Serializable interacts with the
lazy val. It would be useful to know when that lazy val gets instantiated
(hopefully just once when the object is serialized).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
