Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6762#discussion_r33655757
  
    --- Diff: 
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
    @@ -159,6 +162,77 @@ public UTF8String toLowerCase() {
         return UTF8String.fromString(toString().toLowerCase());
       }
     
    +  public UTF8String trim() {
    +    return UTF8String.fromString(toString().trim());
    --- End diff --
    
    my understanding is that in a well-formed utf-8 byte sequence, the last 
byte in a code point cannot be 0x20, unless it is a space character. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to