Github user davies commented on the pull request: https://github.com/apache/spark/pull/7143#issuecomment-117711886 The hard part is that BinaryType could be used in ArrayType and MapType, we need to also fix them. As @marmbrus suggested, it's better to create a wrapper for BinaryType internal, let it handle hashCode and equality check. We can call it `Binary`, it's a large change.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org