Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4984#discussion_r33705725
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
 ---
    @@ -59,9 +62,24 @@ private[spark] class CoarseMesosSchedulerBackend(
     
       val slaveIdsWithExecutors = new HashSet[String]
     
    -  val taskIdToSlaveId = new HashMap[Int, String]
    -  val failuresBySlaveId = new HashMap[String, Int] // How many times tasks 
on each slave failed
    +  val taskIdToSlaveId: HashBiMap[Int, String] = HashBiMap.create[Int, 
String]
    +  // How many times tasks on each slave failed
    +  val failuresBySlaveId: HashMap[String, Int] = new HashMap[String, Int]
    +
    +  // the total number of executors we aim to have
    +  private[mesos] var executorLimitOption: Option[Int] = None
    +
    +  /**
    +   *  Return the current executor limit, which may be [[Int.MaxValue]]
    +   *  before properly initialized.
    +   */
    +  def executorLimit: Int = executorLimitOption.getOrElse(Int.MaxValue)
    --- End diff --
    
    I think this one can be `private[mesos]`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to