Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/7080#discussion_r33738207 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -98,6 +98,15 @@ class LogisticRegression(override val uid: String) def setFitIntercept(value: Boolean): this.type = set(fitIntercept, value) setDefault(fitIntercept -> true) + /** + * Whether to standardize the training features prior to fitting the model sequence. --- End diff -- "model sequence" may not be understood since we don't provide a sequence currently; how about just saying "model?" Also, to make it clear what is meant by standardizing, how about having a link to StandardScaler.withStd?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org