Github user dragos commented on a diff in the pull request:
https://github.com/apache/spark/pull/4984#discussion_r33796575
--- Diff:
network/shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleClient.java
---
@@ -138,6 +139,26 @@ public void registerWithShuffleServer(
client.sendRpcSync(registerMessage, 5000 /* timeoutMs */);
}
+ /**
+ * Removes this application from the external shuffle server and
optionally deletes local
+ * files.
+ *
+ * @param host Host of the shuffle server.
+ * @param port Port of the shuffle server.
+ * @param cleanupLocalDirs True if corresponding shuffle files should be
deleted
+ * @throws IOException
+ */
+ public void applicationRemoved(String host,
+ int port,
--- End diff --
The `ExternalShuffleBlockResolver` is the server part. The client part that
you see here is actually calling that method, through the RPC layer. This class
(the client) is used by executors to connect to other executors for fetching
blocks, and offers a synchronous API on top of the network. In **this** case,
this client is also used by the driver to communicate to *all* executors that
may have shuffle files that need to be deleted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
