Github user suyanNone commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4055#discussion_r33860928
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala 
---
    @@ -1193,8 +1193,10 @@ class DAGScheduler(
             // TODO: This will be really slow if we keep accumulating shuffle 
map stages
             for ((shuffleId, stage) <- shuffleToMapStage) {
               stage.removeOutputsOnExecutor(execId)
    -          val locs = stage.outputLocs.map(list => if (list.isEmpty) null 
else list.head).toArray
    -          mapOutputTracker.registerMapOutputs(shuffleId, locs, changeEpoch 
= true)
    +          if (!runningStages.contains(stage)) {
    --- End diff --
    
    @squito for this one, dagScheduler handler ExecutorLost, it will register 
all `shuffleToMapStage`. Including the running MapStage, which that is not 
complete partial, it will cause we register partial mapStatus into 
MapOutputTracker.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to