GitHub user dbtsai opened a pull request:
https://github.com/apache/spark/pull/7245
[SPARK-8845] [ML] ML use of Breeze optimization: use adjustedValue instead
of value
In LinearRegression and LogisticRegression, we use Breeze's optimizers
(LBFGS and OWLQN). We check the State.value to see the current objective.
However, Breeze's documentation makes it sound like value and adjustedValue
differ for some optimizers, possibly including OWLQN:
https://github.com/scalanlp/breeze/blob/26faf622862e8d7a42a401aef601347aac655f2b/math/src/main/scala/breeze/optimize/FirstOrderMinimizer.scala#L36
If that is the case, then we should use adjustedValue instead of value.
This is relevant to SPARK-8538 and SPARK-8539, where we will provide the
objective trace to the user.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dbtsai/spark SPARK-8845
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/7245.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #7245
----
commit c9ff81e729c82c21d846dbf0d8d531d281abe434
Author: DB Tsai <d...@netflix.com>
Date: 2015-07-06T22:10:28Z
first commit
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
