Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7099#discussion_r33999324
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -194,10 +203,15 @@ class LinearRegression(override val uid: String)
if (handlePersistence) instances.unpersist()
// TODO: Converts to sparse format based on the storage, but may base
on the scoring speed.
- copyValues(new LinearRegressionModel(uid, weights.compressed,
intercept))
+ val model = new LinearRegressionModel(uid, weights.compressed,
intercept)
+ val trainingResults = new LinearRegressionTrainingResults(
+ model.transform(dataset).select(model.getPredictionCol,
model.getLabelCol),
+ lossHistory.result())
--- End diff --
Okay, lossHistory will still be the one returned in the scaled space. It's
not easy and meaningful to convert it into original space.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
