Github user litao-buptsse commented on the pull request:
https://github.com/apache/spark/pull/7055#issuecomment-119163076
@srowen #7125 is for master branch and passed all the test case. You can
consider to merge it to master.
But for branch-1.4, not only contains the bugs, but also need some refactor
to cache up with the master. My first commit
https://github.com/litao-buptsse/spark/commit/cbae84e72cc8c1949e96b0d17c7ff38ca6da7281
is just intend to fix the bugs. The following commits of the #7055 PR is
intend to refactor the branch-1.4 to catch up with master branch.
#7125 for master is ready to merge to master.
But I don't know if I should refactor the branch-1.4? Or it it spark
commiter to cherry-pick some commits from master to branch-1.4?
If no need to do the refactor job,
https://github.com/litao-buptsse/spark/commit/cbae84e72cc8c1949e96b0d17c7ff38ca6da7281
can fix the bugs for branch-1.4 and passed all tests.
If I can continue do the branch-1.4 refactor job, I will follow @tgravescs
's advice and review my code again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
