Github user mallman commented on the pull request:

    https://github.com/apache/spark/pull/6832#issuecomment-119375569
  
    The original code replaces only the first instance of 
`<scala.binary.version>2.10<` in the file, which is the desired behavior. The 
code you presented replaces all of them. You can more clearly see how that's a 
problem if you run that sed commend to change from version 2.10 to 2.11, then 
back again to 2.10, and then run `git diff pom.xml`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to