Github user zeodtr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/899#discussion_r13164860
  
    --- Diff: 
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
    @@ -473,15 +474,15 @@ object ClientBase {
           if (localPath != null) {
             val parentPath = new File(localPath).getParent()
             YarnSparkHadoopUtil.addToEnvironment(env, 
Environment.CLASSPATH.name, parentPath,
    -          File.pathSeparator)
    +          ApplicationConstants.CLASS_PATH_SEPARATOR)
    --- End diff --
    
    I think it will fail for Hadoop < 2.4.
    The hadoop server code that recognizes `<CPS>` was committed at Mar 17 
2014, to resolve YARN-1824. The code is in 
org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.ContainerLaunch.
 ([see this github 
link](https://github.com/apache/hadoop-common/blob/9f02e3a4a70d4affd5342e8fa61666bd8bf59bbb/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/launcher/ContainerLaunch.java))
    So, maybe the best solution that does not require Hadoop 2.4.0 is to build 
the environment variables on the cluster side. (I don't know how to do that - 
is it even possible?)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to