Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/6762#discussion_r34213337
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
---
@@ -188,6 +189,302 @@ case class EndsWith(left: Expression, right:
Expression)
}
/**
+ * A function that trim the spaces from both ends for the specified string.
+ */
+case class StringTrim(child: Expression)
+ extends UnaryExpression with String2StringExpression {
+
+ def convert(v: UTF8String): UTF8String = v.trim()
+
+ override def toString: String = s"TRIM($child)"
--- End diff --
I thought that also, but maybe what we want is the function name, not the
class name, or I can remove the `toString` method directly. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
