Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6762#discussion_r34220506
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -206,6 +207,198 @@ public UTF8String toLowerCase() {
return fromString(toString().toLowerCase());
}
+ /**
+ * Copy the bytes from the current UTF8String, and make a new UTF8String.
+ * @param start the start position of the current UTF8String in bytes.
+ * @param end the end position of the current UTF8String in bytes.
+ * @return a new UTF8String in the position of [start, end] of current
UTF8String bytes.
+ */
+ private UTF8String copyUTF8String(byte[] bytes, int start, int end) {
--- End diff --
+1, this function will create a new object, can we only modify the `base`
or (`offset` and `size`)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
