Github user tarekauel commented on a diff in the pull request:
https://github.com/apache/spark/pull/7208#discussion_r34232283
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
---
@@ -182,8 +184,9 @@ trait StringComparison extends ExpectsInputTypes {
* A function that returns true if the string `left` contains the string
`right`.
*/
case class Contains(left: Expression, right: Expression)
- extends BinaryExpression with Predicate with StringComparison {
+ extends BinaryExpression with Predicate with StringComparison {
--- End diff --
Why have you removed the space? See style-guide
https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide#SparkCodeStyleGuide-Indentation
I would say that `extends` should be indented like a parameter (4 spaces)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
