Github user tarekauel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7115#discussion_r34370691
  
    --- Diff: 
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
    @@ -515,4 +522,45 @@ public int hashCode() {
         }
         return result;
       }
    +
    +  /**
    +   * Encodes a string into a Soundex value. Soundex is an encoding used to 
relate similar names,
    +   * but can also be used as a general purpose scheme to find word with 
similar phonemes.
    +   */
    +  public UTF8String Soundex() {
    +    if (numBytes == 0) {
    +      return UTF8String.fromBytes(new byte[0]);
    +    }
    +    String tmp;
    +    byte data[] = {'0','0','0','0'};
    +    char ch;
    +    int idx = 0;
    +    int offset = numBytesForFirstByte(getByte(0));
    +    if(offset>1)
    +    {
    +        return UTF8String.fromBytes(getBytes());
    --- End diff --
    
    `this`. There is no need to create a new `UTF8String`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to