Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-120571131
@zhangjiajin Let's merge this version and make improvements in follow-up
PRs:
1. `LocalPrefixSpan` performance
a. `run` should output `Iterator` instead of `Array`.
b. Local count shouldn't use `groupBy`, which creates too many arrays. We
can use `PrimitiveKeyOpenHashMap`.
c. We can use list to avoid materialize frequent sequences.
2. If there are not enough length-1 patterns to distribute the work, we
make another pass to find length-2 patterns.
3. Support non-temporal sequences.
I will make JIRAs for each of them. @feynmanliang will work on 1).
@zhangjiajin Could you work on 2) and do some performance benchmark? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
