Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7355#discussion_r34410493
--- Diff:
unsafe/src/test/java/org/apache/spark/unsafe/types/IntervalSuite.java ---
@@ -56,4 +56,34 @@ public void toStringTest() {
i = new Interval(34, 3 * MICROS_PER_WEEK + 13 * MICROS_PER_HOUR + 123);
assertEquals(i.toString(), "interval 2 years 10 months 3 weeks 13
hours 123 microseconds");
}
+
+ @Test
+ public void fromStringTest() {
+ String s;
+ Interval i;
+
+ s = "interval 2 weeks -6 minute";
--- End diff --
add a unit test where there is only # month specified, but nothing else.
and another one with only # year.
and then one more for year + month.
and one for only day, week, ... all the units.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
