Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/6783#discussion_r34432761
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -387,3 +387,96 @@ case class MinOf(left: Expression, right: Expression)
extends BinaryArithmetic {
override def symbol: String = "min"
override def prettyName: String = symbol
}
+
+case class Pmod(left: Expression, right: Expression) extends
BinaryArithmetic {
+
+ override def symbol: String = "pmod"
+
+ protected def checkTypesInternal(t: DataType) =
+ TypeUtils.checkForNumericExpr(t, "pmod")
+
+ override lazy val resolved =
+ childrenResolved && checkInputDataTypes().isSuccess &&
!DecimalType.isFixed(dataType)
+
+ protected override def nullSafeEval(left: Any, right: Any) =
+ dataType match {
+ case IntegerType => pmod(left.asInstanceOf[Integer],
right.asInstanceOf[Integer])
+ case LongType => pmod(left.asInstanceOf[Long],
right.asInstanceOf[Long])
+ case ShortType => pmod(left.asInstanceOf[Short],
right.asInstanceOf[Short])
+ case ByteType => pmod(left.asInstanceOf[Byte],
right.asInstanceOf[Byte])
+ case FloatType => pmod(left.asInstanceOf[Float],
right.asInstanceOf[Float])
+ case DoubleType => pmod(left.asInstanceOf[Double],
right.asInstanceOf[Double])
+ case _: DecimalType => pmod(left.asInstanceOf[Decimal],
right.asInstanceOf[Decimal])
+ }
+
+ override def genCode(ctx: CodeGenContext, ev: GeneratedExpressionCode):
String = {
+ nullSafeCodeGen(ctx, ev, (eval1, eval2) => {
+ dataType match {
+ case dt: DecimalType =>
+ val decimalAdd = "$plus"
--- End diff --
Ok, as we talked offline, this is a exceptional case in
`ArithmeticExpression`, we will take both `$plus` and `remainder` for the
method `decimalMethod`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
