Github user yhuai commented on the pull request:

    https://github.com/apache/spark/pull/7343#issuecomment-120811010
  
    @chenghao-intel Thanks for the update. I find `complex group by keys` is a 
confusing term. If I understand correctly, we do not handle expressions other 
than `AttributeReference`s, right? Also, with your change, seems we will change 
the group by expressions (e.g. from `key % 100` to `key`)? What will happen if 
an expression involves multiple columns (e.g. `key1 + key2`)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to