Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7365#discussion_r34538094
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -421,48 +421,515 @@ case class Cast(child: Expression, dataType:
DataType) extends UnaryExpression w
protected override def nullSafeEval(input: Any): Any = cast(input)
+ private[this] class CodeHolder private() {
--- End diff --
It imitate the behaviour of `defineCodeGen` and `nullSafeCodeGen`, hold the
calculation for either `genCode` if it's a primitive type cast or to be later
used in complex type's members' evaluation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
