GitHub user JoshRosen opened a pull request:
https://github.com/apache/spark/pull/7391
[SPARK-9031] Merge BlockObjectWriter and DiskBlockObject writer to remove
abstract class
BlockObjectWriter has only one concrete non-test class,
DiskBlockObjectWriter. In order to simplify the code in preparation for other
refactorings, I think that we should remove this base class and have only
DiskBlockObjectWriter.
While at one time we may have planned to have multiple BlockObjectWriter
implementations, that doesn't seem to have happened, so the extra abstraction
seems unnecessary.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JoshRosen/spark
shuffle-write-interface-refactoring
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/7391.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #7391
----
commit 1607c913bc4c8de937029871a3cd942c37598533
Author: Josh Rosen <joshro...@databricks.com>
Date: 2015-07-14T00:58:48Z
Merge BlockObjectWriter and DiskBlockObjectWriter
commit 5755918aefc51622e73dfb0c6741c28b70720923
Author: Josh Rosen <joshro...@databricks.com>
Date: 2015-07-14T00:59:30Z
Remove unnecessary val in case class
commit 89dc797f543f0e5bfcc21223f88c9cfd1e10d2ea
Author: Josh Rosen <joshro...@databricks.com>
Date: 2015-07-14T06:36:12Z
Rename test suite.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
