Github user squito commented on the pull request:

    https://github.com/apache/spark/pull/7004#issuecomment-121438591
  
    Thanks for changing the codec @JDrit but unfortunately I think Snappy is 
the one bad choice for a hard-coded compression codec, because it depends on 
native libs.  A user would be really surprised if they had specifically turned 
off snappy compression but got an error from this.  Can we either (a) hardcode 
to something that isn't dependent on a native lib, or (b) just use the same 
compression codec the user already has configured in SparkConf.  I'd strongly 
prefer (b) if possible.  I think it should be straight-forward -- just pass the 
`conf` into the constructor for `GenericAvroSerializer`, and then you can call 
`CompressionCodec.createCodec(conf)`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to