Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/7014#discussion_r34903699
--- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala ---
@@ -97,13 +103,26 @@ case class ExceptionFailure(
description: String,
stackTrace: Array[StackTraceElement],
fullStackTrace: String,
- metrics: Option[TaskMetrics])
+ metrics: Option[TaskMetrics],
+ exceptionWrapper: Option[ThrowableSerializationWrapper])
extends TaskFailedReason {
+ /**
+ * `preserveCause` is used to keep the exception itself so it is
available to the
+ * driver. This may be set to `false` in the event that the exception is
not in fact
+ * serializable.
+ */
+ private[spark] def this(e: Throwable, metrics: Option[TaskMetrics],
preserveCause: Boolean) {
+ this(e.getClass.getName, e.getMessage, e.getStackTrace,
Utils.exceptionString(e), metrics,
+ if (preserveCause) Some(new ThrowableSerializationWrapper(e)) else
None)
+ }
+
private[spark] def this(e: Throwable, metrics: Option[TaskMetrics]) {
- this(e.getClass.getName, e.getMessage, e.getStackTrace,
Utils.exceptionString(e), metrics)
+ this(e, metrics, true)
}
+ def exception = exceptionWrapper.map(_.exception)
--- End diff --
I think this would actually be `Some(null)` in the exceptional case, no?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
