Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7365#discussion_r34948044
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -422,47 +422,487 @@ case class Cast(child: Expression, dataType:
DataType) extends UnaryExpression w
protected override def nullSafeEval(input: Any): Any = cast(input)
override def genCode(ctx: CodeGenContext, ev: GeneratedExpressionCode):
String = {
- // TODO: Add support for more data types.
- (child.dataType, dataType) match {
+ val eval = child.gen(ctx)
+ val nullSafeCast = nullSafeCastFunction(child.dataType, dataType, ctx)
+ if (nullSafeCast != null) {
+ eval.code +
+ castCode(ctx, eval.primitive, eval.isNull, ev.primitive,
ev.isNull, dataType, nullSafeCast)
+ } else {
+ super.genCode(ctx, ev)
--- End diff --
castCode is intendedly take all these parameters because we have to do cast
for `ComplexType` as well, so we need call castCode recursively in these casts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
