Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/7208#discussion_r35216353
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
---
@@ -595,6 +595,34 @@ case class StringFormat(children: Expression*) extends
Expression with ImplicitC
}
/**
+ * Returns string, with the first letter of each word in uppercase,
+ * all other letters in lowercase. Words are delimited by whitespace.
+ */
+case class InitCap(child: Expression) extends UnaryExpression
+ with ExpectsInputTypes with CodegenFallback {
+ override def dataType: DataType = StringType
+
+ override def inputTypes: Seq[DataType] = Seq(StringType)
+
+ override def nullSafeEval(string: Any): Any = {
+ if (string.asInstanceOf[UTF8String].getBytes.length == 0) {
--- End diff --
`getBytes` probably cause memory copying, let's call the function
`numBytes()` instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
