Github user EntilZha commented on a diff in the pull request: https://github.com/apache/spark/pull/7580#discussion_r35239410 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -35,3 +37,57 @@ case class Size(child: Expression) extends UnaryExpression with ExpectsInputType nullSafeCodeGen(ctx, ev, c => s"${ev.primitive} = ($c).size();") } } + +case class ArrayContains(left: Expression, right: Expression) extends BinaryExpression { + override def dataType: DataType = BooleanType + + override def checkInputDataTypes(): TypeCheckResult = { + if (!left.dataType.isInstanceOf[ArrayType]) { + TypeCheckResult.TypeCheckFailure( + s"type of first input must be an array, not ${left.dataType.simpleString}") + } else if (left.dataType.asInstanceOf[ArrayType].elementType != right.dataType) { + TypeCheckResult.TypeCheckFailure( + s"type of value must match array type " + + s"${left.dataType.asInstanceOf[ArrayType].elementType.simpleString}, not "+ + s"${right.dataType.simpleString}") + } else { + TypeCheckResult.TypeCheckSuccess + } + } + + override def eval(input: InternalRow): Boolean = { --- End diff -- On that note, there isn't any documentation for `nullable`. Am I correct in assuming that if `nullable` is `false`, then the expression cannot return `null`? Can I add a comment with this if its correct?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org