Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/7584#discussion_r35289630
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1384,7 +1384,7 @@ setMethod("saveAsTable",
"org.apache.spark.sql.parquet")
}
allModes <- c("append", "overwrite", "error", "ignore")
- if (!(mode %in% allModes)) {
+ if (! (mode %in% allModes)) {
--- End diff --
I checkout the source code of the R interpreter, the most common style of
using ! is:
!<var>, !<function call> and !(<expression>)
while there is still in-consistency of this style in the R source code like:
!<space><expression>, ! <function call>, ...
I prefer to the former style. Take the following as example:
! dots.or.missing(e) && length(e) == 3
The real meaning of the expression is (! dots.or.missing(e)) && length(e)
== 3, but seems like
! (dots.or.missing(e) && length(e) == 3)
So the following looks better:
!dots.or.missing(e) && length(e) == 3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
